Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating react-native-render-html version #6582

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Updating react-native-render-html version #6582

merged 1 commit into from
Dec 6, 2021

Conversation

chiragsalian
Copy link
Contributor

@chiragsalian chiragsalian commented Dec 3, 2021 •
edited
Loading

The only reason we just needed to update the react-native-render-html version is because,

6.3.1 (2021-12-03)
Bug Fixes
bold style not applied to <b> tags (7bd5045), closes #539

they fixed rendering b tag in their recent version. It was always working with italics. And for strikethrough we were stripping it in the backend but this PR will allow it in future.

Details

Fixed Issues

$ #4899

Tests

  1. Set up your mailgun to receive newDot message comments via email. Confirm you have this web-E code.
  2. I tested with the following email.
    image
  3. Confirmed the message i received in newDot had bold, italics and strikethrough just fine.
    image

QA Steps

  1. Reply to a chat via email with bold, italics and strikethrough. (P.S strikethrough will only work if this PR is live, if its not live ignore it and we'll test it later)
    image
  2. Confirm the message was received in newDot properly.
    image

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@chiragsalian chiragsalian self-assigned this Dec 3, 2021
@chiragsalian chiragsalian marked this pull request as ready for review December 3, 2021 22:17
@chiragsalian chiragsalian requested a review from a team as a code owner December 3, 2021 22:17
@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team December 3, 2021 22:17
@marcochavezf
Copy link
Contributor

Hi @chiragsalian the bold format looks good but for some reason the strikethrough format is not shown in new dot:

Screen Shot 2021-12-06 at 11 20 09

Screen Shot 2021-12-06 at 11 21 53

@marcochavezf
Copy link
Contributor

Oh nvm, I updated Web-E and now looks good:

Screen Shot 2021-12-06 at 11 31 12

Screen Shot 2021-12-06 at 11 31 33

@marcochavezf marcochavezf merged commit b31eb39 into main Dec 6, 2021
@marcochavezf marcochavezf deleted the chirag-updating-react-native-render-html branch December 6, 2021 17:33
@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Dec 6, 2021
Closed
95 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @marcochavezf in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mvtglobally
Copy link

@chiragsalian PR https://github.com/Expensify/Web-Expensify/pull/32544 doesn't seem to be live. Is it ok to check off this or should we still QA?

@mvtglobally
Copy link

It just deployed. We are testing

@mvtglobally mvtglobally mentioned this pull request Dec 8, 2021
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcochavezf marcochavezf marcochavezf approved these changes

Assignees

@chiragsalian chiragsalian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chiragsalian @marcochavezf @OSBotify @mvtglobally